Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transformer/class-properties): transform private field expression which invokes private method #8102

Draft
wants to merge 1 commit into
base: 12-25-feat_transformer_class-properties_transform_callee_that_is_referred_to_a_private_method
Choose a base branch
from
Draft

feat(transformer/class-properties): transform private field expression which invokes private method #8102

wants to merge 1 commit into from
+143 −67

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 25, 2024

No description provided.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Dec 25, 2024
This was referenced Dec 25, 2024
Draft
Draft
Draft
@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Dec 25, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the title feat(transformer/class-properties): transform private field expression which refers to private method feat(transformer/class-properties): transform private field expression which invokes private method Dec 25, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 25, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #8102 will create unknown performance changes

Comparing 12-25-feat_transformer_class-properties_transform_private_field_expression_which_refers_to_private_method (8fac581) with 12-25-feat_transformer_class-properties_transform_callee_that_is_referred_to_a_private_method (d88a83a)

Summary

🆕 29 new benchmarks

Benchmarks breakdown

Benchmark 12-25-feat_transformer_class-properties_transform_callee_that_is_referred_to_a_private_method 12-25-feat_transformer_class-properties_transform_private_field_expression_which_refers_to_private_method Change
🆕 codegen[checker.ts] N/A 25 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 68.6 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 725.7 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 23.9 µs N/A
🆕 lexer[antd.js] N/A 22.3 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.5 ms N/A
🆕 lexer[checker.ts] N/A 13.2 ms N/A
🆕 lexer[pdf.mjs] N/A 3.6 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.5 ms N/A
🆕 linter[cal.com.tsx] N/A 1.1 s N/A
🆕 linter[checker.ts] N/A 2.7 s N/A
🆕 minifier[antd.js] N/A 219 ms N/A
🆕 minifier[react.development.js] N/A 2 ms N/A
🆕 minifier[typescript.js] N/A 381.8 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 87.8 µs N/A
🆕 parser[antd.js] N/A 107.3 ms N/A
🆕 parser[cal.com.tsx] N/A 29.6 ms N/A
🆕 parser[checker.ts] N/A 54.1 ms N/A
🆕 parser[pdf.mjs] N/A 17.5 ms N/A
🆕 semantic[RadixUIAdoptionSection.jsx] N/A 74.2 µs N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Dunqing Dunqing force-pushed the 12-25-feat_transformer_class-properties_transform_private_field_expression_which_refers_to_private_method branch 2 times, most recently from fa38824 to 4f5439b Compare December 25, 2024 05:11
This was referenced Dec 25, 2024
Draft
Draft
Draft
Draft
@Dunqing Dunqing force-pushed the 12-25-feat_transformer_class-properties_transform_callee_that_is_referred_to_a_private_method branch from 02c7724 to 1f5bb38 Compare December 26, 2024 02:33
@Dunqing Dunqing force-pushed the 12-25-feat_transformer_class-properties_transform_private_field_expression_which_refers_to_private_method branch from 4f5439b to 16ffd41 Compare December 26, 2024 02:33
This was referenced Dec 26, 2024
Draft
Draft
@Dunqing Dunqing force-pushed the 12-25-feat_transformer_class-properties_transform_callee_that_is_referred_to_a_private_method branch from 1f5bb38 to 5a7932b Compare December 26, 2024 11:24
@Dunqing Dunqing force-pushed the 12-25-feat_transformer_class-properties_transform_private_field_expression_which_refers_to_private_method branch from 16ffd41 to 8255221 Compare December 26, 2024 11:25
@Dunqing Dunqing mentioned this pull request Dec 26, 2024
Draft
@Dunqing Dunqing force-pushed the 12-25-feat_transformer_class-properties_transform_callee_that_is_referred_to_a_private_method branch from 5a7932b to 558357d Compare December 26, 2024 16:11
@Dunqing Dunqing force-pushed the 12-25-feat_transformer_class-properties_transform_private_field_expression_which_refers_to_private_method branch 2 times, most recently from 3745697 to 3616de3 Compare December 26, 2024 16:41
@Dunqing Dunqing force-pushed the 12-25-feat_transformer_class-properties_transform_callee_that_is_referred_to_a_private_method branch from 558357d to d88a83a Compare December 28, 2024 09:05
@Dunqing Dunqing force-pushed the 12-25-feat_transformer_class-properties_transform_private_field_expression_which_refers_to_private_method branch from 3616de3 to 8fac581 Compare December 28, 2024 09:05
@Dunqing Dunqing mentioned this pull request Dec 28, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel will be requested when the pull request is marked ready for review overlookmotel is a code owner

Assignees
No one assigned
Labels
A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Dunqing